Skip to content

ci: consolidate workflows into ci.yml#18139

Open
pettinarip wants to merge 1 commit intodevfrom
ci/consolidate-workflows
Open

ci: consolidate workflows into ci.yml#18139
pettinarip wants to merge 1 commit intodevfrom
ci/consolidate-workflows

Conversation

@pettinarip
Copy link
Copy Markdown
Member

@pettinarip pettinarip commented May 6, 2026

Description

Consolidates tests.yml, lint-markdown.yml, chromatic.yml, chromatic-pages.yml, and lighthouse-ci.yml into a single .github/workflows/ci.yml.

What's in ci.yml

7 jobs, all triggered on PR sync:

  • lint — ESLint, tsc --noEmit, markdown lint on changed files
  • unit-testspnpm test:unit
  • visual-tests — Storybook → Chromatic
  • build — single mock-data build (en/es/zh/ar) shared as next-build artifact
  • e2e — Playwright against the Netlify deploy preview (was previously workflow_dispatch-only — now automated)
  • lighthouse — local server from build artifact, posts sticky PR comment
  • page-visual — Playwright + Chromatic Pages, runs in mcr.microsoft.com/playwright container

Extended jobs (everything except lint + unit) gate on PRs targeting master/staging/test/**.

Notable changes outside the workflow

  • next-env.d.ts committed (removed from .gitignore) — Next.js docs require this; without it, tsc fails on @/public/*.png imports because the next/image-types/global reference is missing.
  • type-check script added to package.json.
  • Composite actions under .github/actions/: setup-pnpm-node (pnpm + Node-from-.nvmrc + install) and wait-for-server.
  • Action versions bumped: actions/github-script@v3@v7, chromaui/action@v1@v16, marocchino/sticky-pull-request-comment@v2.0.0@v2.

Test plan

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for ethereumorg canceled.

Name Link
🔨 Latest commit 9e5b513
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69fc94959e31e1000873c735

@github-actions github-actions Bot added dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project labels May 6, 2026
@pettinarip pettinarip force-pushed the ci/consolidate-workflows branch 3 times, most recently from 46b2c92 to 7062c1e Compare May 6, 2026 20:48
@pettinarip pettinarip closed this May 7, 2026
@github-actions github-actions Bot added the abandoned This has been abandoned or will not be implemented label May 7, 2026
@pettinarip pettinarip reopened this May 7, 2026
@pettinarip pettinarip force-pushed the ci/consolidate-workflows branch from 9e5b513 to efc481a Compare May 7, 2026 14:04
@pettinarip pettinarip force-pushed the ci/consolidate-workflows branch from efc481a to c0503c3 Compare May 7, 2026 14:06
@pettinarip pettinarip marked this pull request as ready for review May 7, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abandoned This has been abandoned or will not be implemented dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant