ci: consolidate workflows into ci.yml#18139
Open
pettinarip wants to merge 1 commit intodevfrom
Open
Conversation
✅ Deploy Preview for ethereumorg canceled.
|
5 tasks
46b2c92 to
7062c1e
Compare
9e5b513 to
efc481a
Compare
efc481a to
c0503c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates
tests.yml,lint-markdown.yml,chromatic.yml,chromatic-pages.yml, andlighthouse-ci.ymlinto a single.github/workflows/ci.yml.What's in
ci.yml7 jobs, all triggered on PR sync:
tsc --noEmit, markdown lint on changed filespnpm test:unitnext-buildartifactworkflow_dispatch-only — now automated)mcr.microsoft.com/playwrightcontainerExtended jobs (everything except lint + unit) gate on PRs targeting
master/staging/test/**.Notable changes outside the workflow
next-env.d.tscommitted (removed from.gitignore) — Next.js docs require this; without it,tscfails on@/public/*.pngimports because thenext/image-types/globalreference is missing.type-checkscript added topackage.json..github/actions/:setup-pnpm-node(pnpm + Node-from-.nvmrc+ install) andwait-for-server.actions/github-script@v3→@v7,chromaui/action@v1→@v16,marocchino/sticky-pull-request-comment@v2.0.0→@v2.Test plan
test/ci-validationvalidation PR (ci: validate consolidated workflows (extended path) #18140, now closed)master/stagingwill exercise the extended path